PivityGmodStore

Initialization issues

Hello.

This tutorial will explain how to fix the issue you can have when opening the television menu, and when having this error thrown in client console:

[the_perfect_training_system] addons/the_perfect_training_system/lua/diablos_training/vgui/cl_training_stats.lua:123: attempt to index local 'trainingData' (a nil value)
 1. changePanel - addons/the_perfect_training_system/lua/diablos_training/vgui/cl_training_stats.lua:123
  2. func - addons/the_perfect_training_system/lua/diablos_training/vgui/cl_training_stats.lua:517
  3. unknown - lua/includes/extensions/net.lua:33


Explanation

This error is caused by a initialization issue, caused by a conflicting addon.

The reason is that there is no "PlayerFullLoad" hook serverside, so to do so, as stated in the PlayerInitialSpawn hook, we need to put a custom code. Then, using it, and thanks to this line:

hook.Run( "PlayerFullLoad", self )


All creators are able to create a hook launched when the player is full loaded, ie on my addon:

hook.Add("PlayerFullLoad", "TPTSA:FullLoadSetupHook", function(ply)
-- my code goes here
end)


However, as written in the example, there is this line:

hook.Remove("SetupMove", ply)

as the SetupMove is launched each frame, so there is no point to launch it each frame while the PlayerFullLoad hook has been ran. With this line, SetupMove hooks with ply (player data) identifiers will be removed.


Nevertheless, some people are editing what's stated in the Wiki article for PlayerInitialSpawn, and are not running PlayerFullLoad, but their own hook.

For example (but it is not the only one), the addon below has this bunch of code:

hook.Add("PlayerInitialSpawn", "SummeLibrary.PlayerReady", function(ply)
    hook.Add("SetupMove", ply, function(self, ply, _, cmd)
      if self == ply and not cmd:IsForced() then
        hook.Run("SummeLibrary.PlayerReady", self)
        hook.Remove("SetupMove", self)
      end
    end)
  end)


The hook run will be SummeLibrary.PlayerReady, and then all SetupMove hooks with the player identifier will be deleted. It means that when my code is inside the hook PlayerFullLoad, that hook is never being called, therefore the training data is not being initialized correctly leading to an error!


In that context, the first PlayerInitialSpawn hook with a SetupMove hook will be launched, and will be the only SetupMove hook launched (as the others will be deleted). For more consistency, we should let the Wiki example, running a PlayerFullLoad hook and all creators should play with it instead of customizing this part of the code.



Fix


If you want to fix it, the best way to do so is to look on all your addons in the addons/ folder (using the Find in Files feature on your text editor) and look for "SetupMove".

Note: you also need to check your Workshop addons as they could be the conflicting addon


After checking for your whole addons/ folder, see the result.

Here, I can see a SetupMove with a "ply" (player data) identifier (second argument of hook.Add) so it is a potential issue.

The interesting line is the line 41, with the hook run:

hook.Run("SummeLibrary.PlayerReady", self)

The hook run is not PlayerFullLoad, but his own hook. However, SetupMove hooks (including mine) are also being removed next line (line 42), so the training data is never being launched as the PlayerFullLoad hooks will never be run.


To fix it, look for the hook name "SummeLibrary.PlayerReady" in your whole addons/ folder.

Change it by:

  1. PlayerFullLoad


You need to do that for all the addons which are running their own hooks (in case they are the first hook being launched).



Known addons causing this


I will update the list with the known addons who changed the part of the code as if they lived in their own little island:

  1. Summe library
  2. ...