Hire Me!
no!
just kidding, you have done some work for me in the past with mining scripts etc and always done good work GLWS!
So what you are essentially doing here is looping through ents.GetAll for every npc in your table ( in this case 11 times!). Considering that ents.GetAll on its own is very heavy and should basicly never be used in a Think unless necessary just think about what it means if you do it 11 times each think. A very loaded Server can have hundreads of entities you are going through one by one and running a function on each one.
Considering you say you love to optimize your code, what you should have done is making a local table saving all spawned npcs with your class and then looping through that instead of calling ents.GetAll 11 times each Think. Now you are ofc going to argue that there is a cooldown but first of all you still have the same problem, just not as often, and second your cooldown is not functioning correctly either:
Because you are only using one cooldown for every NPCS, but your "Feature" to give every NPC different Play Rates would requiere each NPC to have its own cooldown, also here you are resetting the cooldown 11 times, because you do it in the loop and not after the loop is finished.
Otherwise you could/should have also used table keys instead of values for validation.
So instead of
for k,v in pairs(ents.GetAll()) do if v:GetClass() == "thingIwant" then print(v) break end
local table = { ["thingIwant"] = true }
for k,v in pairs(ents.GetAll()) do if table[v:GetClass()] then print(v) break end
That saves you a lot of loops and is better overall, there is also a special site on the gmod wiki just dedicated to this method.
Otherwise regarding customers happiness let me just say this:
I hope this is enough evidence for you
hmm